Update pyproject.toml - #176
Conversation
| "pre-commit", | ||
| "euphonic==1.3.0", | ||
| "aiida-vibroscopy~=1.3.0", | ||
| "aiida-phonopy~=1.2.1", |
There was a problem hiding this comment.
Pinning to minor versions is possibly still problematic, since any updates then need to be coordinated between all plugins at once (for common dependencies)
There was a problem hiding this comment.
Plus we should aimed to introducing aiida-vibroscopy latest for the newest implementations
There was a problem hiding this comment.
@danielhollas I don't quite understand. Can you clarify what you're suggesting here? Note that there is complexity here in any case, as often AiiDA plugin developers move faster than AiiDAlab plugin developers.
There was a problem hiding this comment.
Fair enough, it's probably wise to pin to minor versions.
This PR is mostly about unpinning the patch versions.
- remove pre-commit from dependencies - relax version pins to allow at least patch version updates - add numpy as a build depedency for euphonic
88e76f0 to
febc66c
Compare
|
CC @mikibonacci @cpignedoli this is ready for review |
mikibonacci
left a comment
mikibonacci
left a comment
There was a problem hiding this comment.
LGTM! thanks @danielhollas
I'll also update the aiidalab-qe-muon plugin accordingly
4 participants
add numpy as a build depedency for euphonic (fixes build failure in Fix override aiidalab-qe#517)Similar relaxation of version pin should probably be done for the muon plugin to prevent conflicts.